-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Revision of Experiments Tutorials and 'Theoretically Working' adaptations to OMF6 #5
Open
mitchmusarra
wants to merge
44
commits into
mytestbed:master
Choose a base branch
from
mitchmusarra:master
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Code is set out clearer and comments are slightly simplified.
Added markdown feature that highlights ruby syntax
Code is layed out nicer and easier to read and understand by a potential experimenter + Very minor changes to actual code to prevent WARN errors + Fixed spelling errors and sentences
Comments are more relevant to code
Fixed some description mistakes and replicated to tutorial files + created new tutorial ruby file
+ Added references to 'ED' in comments rather than 'OML2 Application'
Changed 'g.application' to 'node.application' to work with new code style
Syntax OK
ERROR Object: undefined local variable or method `a' for main:Object ERROR Object: ex3.rb:17:in `block in <top (required)>'
Correctly changed 'a' to 'app.' to associate with |app| group
+ Changed groups to |app|
Exception of 'allGroups.net.w0' 'net' option not implemented in OMF6
Changed application definition to work with OMF6 + Addressed some errors: 14:29:01 WARN OmfEc: [DEPRECATION] 'path=' is deprecated. Please use 'binary_path=' instead. 14:29:01 WARN OmfEc: [DEPRECATION] 'version' is deprecated and not supported. Please do not use it. 14:29:01 WARN OmfEc: [DEPRECATION] 'shortDescription=' is deprecated. Please use 'description=' instead.
Replaced 'wait' with 'after' Changed 'addApplication' definitions Specified a subnet mask on IP addresses (24) Changed to nodes 9 and 10
ERROR OmfCommon: Exception 'undefined method `call' for nil:NilClass'
ERROR Object: undefined method `addPrototype' Prototype experiment appears to be unsuported unless definition of 'Protoype' is avaliable
ERROR OmfCommon: Exception 'undefined method `call' for nil:NilClass'
otg2 errors: ERROR Server URI '' seems to be empty ERROR Error parsing server destination URI ''; failed to create stream for this destination
Reverted to 'wait' to stop experiment. ERROR OmfCommon: Exception 'undefined method `call' for nil:NilClass'
'NET' Option #Not implemented in OMF6 - New syntax required for experiment to work
Method of specifying nodes and further adapting code to OMF6
ERROR OmfCommon: Exception 'undefined method `call' for nil:NilClass'
`addPrototype' Must be defined ERROR OmfCommon: Exception 'undefined method `call' for nil:NilClass'
'node.net ' #Currently not working - new syntax required for experiment to work
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Christoph,
Experiment ruby files and tutorial files 1-3 are theoretically complete to use on the website. Filenames, experiment names, experiment output, etc has been modified to work with the changes I have made to the EDs.
Experiment tutorials 4-8 have the .draft extension as they are incomplete; I do not have enough knowledge and experience in OMF6 to accurately revise the existing tutorials myself. The experiment ruby files themselves however are theoretically working with the exception of the 'net' and '%' problems/non-implementations discussed earlier. The ruby code has simplified commented sections which should assist with future revisions.
I have also changed the filenames, eg 'TUTORIAL_01.mkd' to 'Experiment01.mkd' and 'tutorial01.rb' to 'experiment01.rb'. I guess this change will allow for better user readability.
Although the experiment tutorials and EDs will require significantly more changes as OMF evolves, these commits should serve as a solid base for these future revisions.
~Mitch